From 8be46d66315fc47df5634d7cface5b62d7673b26 Mon Sep 17 00:00:00 2001
From: Lily Chen <[email protected]>
Date: Tue, 14 Oct 2025 13:12:42 -0700
Subject: [PATCH] Protect download bubble from unintended key events

This change considers key events when protecting the download bubble row
view from unintended user input. Clicking (or pressing Enter) on the
download bubble row view may result in opening a downloaded file. The
existing InputEventActivationProtector prevents clicks too soon after
showing the download bubble (500 ms). After this change, key events are
subject to the delay as well.

This is only a partial mitigation for a number of variants of
"enterjacking" on the download bubble, because the 500 ms delay may not
be sufficient to catch all unintended keypresses.

Bug: 392375329, 405727341, 421348748, 421877606
Change-Id: Ia6252f397966dd1d5cb539bf5c58f348effebadc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7041986
Reviewed-by: Daniel Rubery <[email protected]>
Auto-Submit: Lily Chen <[email protected]>
Commit-Queue: Lily Chen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1529740}
---

diff --git a/chrome/browser/ui/views/download/bubble/download_bubble_row_view.cc b/chrome/browser/ui/views/download/bubble/download_bubble_row_view.cc
index c4548ce..1e53672 100644
--- a/chrome/browser/ui/views/download/bubble/download_bubble_row_view.cc
+++ b/chrome/browser/ui/views/download/bubble/download_bubble_row_view.cc
@@ -638,7 +638,7 @@
     return;
   }
   if (input_protector_->IsPossiblyUnintendedInteraction(
-          event, /*allow_key_events=*/true)) {
+          event, /*allow_key_events=*/false)) {
     return;
   }
   if (info_->has_subpage()) {
@@ -657,7 +657,7 @@
     const ui::Event& event) {
   if (!bubble_controller_ || !info_->model() ||
       input_protector_->IsPossiblyUnintendedInteraction(
-          event, /*allow_key_events=*/true)) {
+          event, /*allow_key_events=*/false)) {
     return;
   }
   bubble_controller_->ProcessDownloadButtonPress(info_->model()->GetWeakPtr(),