Chrome · Permission Prompts
CVE-2025-1923
Logic Error in Permission Prompts
Overview
Low
Severity
—
CVSS
No
Exploited ITW
Fixed
Fix Status
Files Changed
chrome/browser/ui/views/permissions/chooser_bubble_ui.cc
Patch
From 59f1d4281a72b19732f63b3232d7c31340ba857d Mon Sep 17 00:00:00 2001 From: Keren Zhu <[email protected]> Date: Tue, 28 Jan 2025 09:13:13 -0800 Subject: [PATCH] Set a higher z-order sublevel for the permission chooser bubble This change prevents the permission chooser bubble from being occluded by the extension bubble. This permission bubble is used to choose WebUSB device, etc. Bug: 382540635 Change-Id: Ib6aa62e7342fa475cc89d12fe3e9abe1439b47ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6204583 Reviewed-by: Caroline Rising <[email protected]> Code-Coverage: [email protected] <[email protected]> Auto-Submit: Keren Zhu <[email protected]> Commit-Queue: Caroline Rising <[email protected]> Cr-Commit-Position: refs/heads/main@{#1412341} --- diff --git a/chrome/browser/ui/views/permissions/chooser_bubble_ui.cc b/chrome/browser/ui/views/permissions/chooser_bubble_ui.cc index 9afd48e..75f70d3e 100644 --- a/chrome/browser/ui/views/permissions/chooser_bubble_ui.cc +++ b/chrome/browser/ui/views/permissions/chooser_bubble_ui.cc @@ -13,6 +13,7 @@ #include "chrome/browser/ui/browser_finder.h" #include "chrome/browser/ui/browser_window.h" #include "chrome/browser/ui/views/bubble_anchor_util_views.h" +#include "chrome/browser/ui/views/chrome_widget_sublevel.h" #include "chrome/browser/ui/views/device_chooser_content_view.h" #include "chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h" #include "chrome/browser/ui/views/title_origin_label.h" @@ -285,6 +286,7 @@ base::OnceClosure close_closure = bubble->MakeCloseClosure(); views::Widget* widget = views::BubbleDialogDelegateView::CreateBubble(std::move(bubble)); + widget->SetZOrderSublevel(ChromeWidgetSublevel::kSublevelSecurity); if (browser->window()->IsActive()) { widget->Show(); } else {
Loading diff…
Original Bug Report
reported by [email protected]
Extension popup can appear over WebUSB permission prompt
Steps to reproduce the problem
- Install attached extension
- Click anywhere, then Press Ctrl+A
Problem Description
Similar to issue 361711121
Summary
Extension popup can appear over WebUSB permission prompt
Additional Data
Category: Security
Chrome Channel: Canary
Regression: N/A
References
On This Page