From 33395e4fe24b9dc5b435db658d992f68c758af43 Mon Sep 17 00:00:00 2001
From: Jakob Linke <[email protected]>
Date: Thu, 30 Apr 2026 09:32:00 +0200
Subject: [PATCH] [array-buffer] Defer AttachView in DataView ctor past detach check

The DataView constructor registered the new view on the underlying
ArrayBuffer (via AttachView) before the second IsDetachedBuffer
check. If the byteLength arg's valueOf (or new.target.prototype's
getter) detached the buffer, AttachView ran on a detached buffer
and the orphan view leaked into its `views` field even though the
constructor threw, violating the tracking invariant verified by
--verify-heap.

Move AttachView to immediately after the second IsDetachedBuffer
check. The remaining constructor steps (ArrayBufferByteLength read,
RAB offset/length range checks) cannot run user code, so the buffer
cannot become detached past that point.

AttachView must still run before those RAB range checks: if we
deferred it further and one of them threw on a resized-but-not-
detached buffer, the orphan view would have `views == kNoView`
while WasDetached() is false, which violates
CheckArrayBufferViewTrackingConsistency (see test262
DataView/custom-proto-access-resizes-buffer-*).

Fixed: 506855825
Change-Id: Ib65499805b5e75b09c999e3c0e07dfac49f575d9
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7806344
Auto-Submit: Jakob Linke <[email protected]>
Reviewed-by: Olivier Flückiger <[email protected]>
Commit-Queue: Olivier Flückiger <[email protected]>
Cr-Commit-Position: refs/heads/main@{#106956}
---

diff --git a/src/builtins/builtins-dataview.cc b/src/builtins/builtins-dataview.cc
index 4c0a7cd..952845d 100644
--- a/src/builtins/builtins-dataview.cc
+++ b/src/builtins/builtins-dataview.cc
@@ -143,8 +143,6 @@
     raw->set_buffer(*array_buffer);
   }
 
-  array_buffer->AttachView(*data_view);
-
   // 13. If IsDetachedBuffer(buffer) is true, throw a TypeError exception.
   if (array_buffer->was_detached()) {
     THROW_NEW_ERROR_RETURN_FAILURE(
@@ -154,6 +152,13 @@
             isolate->factory()->NewStringFromAsciiChecked(kMethodName)));
   }
 
+  // AttachView only after the detach check, so a detached buffer does not end
+  // up tracking a view that is never returned to script (the orphan view's
+  // WasDetached() would still be true, but the buffer's views list would be
+  // inconsistent with its detached state). The remaining steps below cannot
+  // detach the buffer, so attaching here is safe.
+  array_buffer->AttachView(*data_view);
+
   // 14. Let getBufferByteLength be
   //     MakeIdempotentArrayBufferByteLengthGetter(SeqCst).
   // 15. Set bufferByteLength be getBufferByteLength(buffer).
diff --git a/test/mjsunit/regress/regress-506855825.js b/test/mjsunit/regress/regress-506855825.js
new file mode 100644
index 0000000..4e4f87f
--- /dev/null
+++ b/test/mjsunit/regress/regress-506855825.js
@@ -0,0 +1,11 @@
+// Copyright 2026 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Flags: --verify-heap --track-array-buffer-views
+
+const ab = new ArrayBuffer(64);
+new Uint8Array(ab);
+
+const evil = { valueOf() { ab.transfer(); return 3; } };
+assertThrows(() => new DataView(ab, 0, evil), TypeError);

diff --git a/test/mjsunit/regress/regress-506855825.js b/test/mjsunit/regress/regress-506855825.js
new file mode 100644
index 0000000..4e4f87f
--- /dev/null
+++ b/test/mjsunit/regress/regress-506855825.js
@@ -0,0 +1,11 @@
+// Copyright 2026 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Flags: --verify-heap --track-array-buffer-views
+
+const ab = new ArrayBuffer(64);
+new Uint8Array(ab);
+
+const evil = { valueOf() { ab.transfer(); return 3; } };
+assertThrows(() => new DataView(ab, 0, evil), TypeError);